From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [RESEND PATCH v4 2/2] net: ethernet: nixge: Add support for
 National Instruments XGE netdev
Date: Thu, 1 Mar 2018 21:11:35 +0100
Message-ID: <20180301201135.GA343@lunn.ch>
References: <20180301191547.2816-1-mdf@kernel.org>
 <20180301191547.2816-2-mdf@kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        robh+dt@kernel.org, mark.rutland@arm.com, f.fainelli@gmail.com,
        davem@davemloft.net
To: Moritz Fischer <mdf@kernel.org>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20180301191547.2816-2-mdf@kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

Hi Moritz

> - Consistency for NIXGE_MDIO_CXX_READ constants

> +#define NIXGE_MDIO_CLAUSE45	BIT(12)
> +#define NIXGE_MDIO_CLAUSE22	0
> +#define NIXGE_MDIO_OP(n)     (((n) & 0x3) << 10)
> +#define NIXGE_MDIO_OP_ADDRESS	0
> +#define NIXGE_MDIO_OP_WRITE	BIT(0)
> +#define NIXGE_MDIO_C45_READ	(BIT(1) | BIT(0))
> +#define NIXGE_MDIO_C22_WRITE	BIT(0)
> +#define NIXGE_MDIO_C22_READ	BIT(1)

Thanks for making READ consistent. But what about WRITE?  I'd suggest
you don't just blindly follow comments, but think about them.

    Andrew