From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:56795 "EHLO
        out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1161467AbeCAUMN (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 1 Mar 2018 15:12:13 -0500
Date: Thu, 1 Mar 2018 22:12:09 +0200
From: Ido Schimmel <idosch@idosch.org>
To: David Ahern <dsahern@gmail.com>
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
        idosch@mellanox.com, jiri@mellanox.com
Subject: Re: [PATCH net-next 1/5] selftests: forwarding: Only check tc
 version for tc tests
Message-ID: <20180301201209.GA8190@splinter>
References: <20180301190947.7299-1-dsahern@gmail.com>
 <20180301190947.7299-2-dsahern@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180301190947.7299-2-dsahern@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, Mar 01, 2018 at 11:09:43AM -0800, David Ahern wrote:
> Capabilities of tc command are irrelevant for router tests:
>     $ ./router.sh
>     SKIP: iproute2 too old, missing shared block support
> 
> Add a CHECK_TC flag and only check tc capabilities if set. Add flag to
> tc_common.sh and have it sourced before lib.sh
> 
> Also, if the command lacks some feature the test should exit non-0.
> 
> Signed-off-by: David Ahern <dsahern@gmail.com>
> ---
>  tools/testing/selftests/net/forwarding/lib.sh      | 29 ++++++++++++++--------
>  .../testing/selftests/net/forwarding/tc_actions.sh |  2 +-
>  .../testing/selftests/net/forwarding/tc_chains.sh  |  2 +-
>  .../testing/selftests/net/forwarding/tc_common.sh  |  2 ++
>  .../testing/selftests/net/forwarding/tc_flower.sh  |  2 +-
>  .../selftests/net/forwarding/tc_shblocks.sh        |  2 +-

bridge_vlan_aware.sh also uses tc to check flooding and learning. Looks
good otherwise.

Reviewed-by: Ido Schimmel <idosch@mellanox.com>

Thanks, David!