From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Ka-Cheong Poon <ka-cheong.poon@oracle.com>
Cc: netdev@vger.kernel.org, santosh.shilimkar@oracle.com,
davem@davemloft.net, rds-devel@oss.oracle.com
Subject: Re: [PATCH v2 net] rds: Incorrect reference counting in TCP socket creation
Date: Fri, 2 Mar 2018 06:18:13 -0500 [thread overview]
Message-ID: <20180302111813.GA853@oracle.com> (raw)
In-Reply-To: <571d10d5825c713cbe9b77ba76ea281761bcc8d7.1519967005.git.ka-cheong.poon@oracle.com>
On (03/01/18 21:07), Ka-Cheong Poon wrote:
> Commit 0933a578cd55 ("rds: tcp: use sock_create_lite() to create the
> accept socket") has a reference counting issue in TCP socket creation
> when accepting a new connection. The code uses sock_create_lite() to
> create a kernel socket. But it does not do __module_get() on the
> socket owner. When the connection is shutdown and sock_release() is
> called to free the socket, the owner's reference count is decremented
> and becomes incorrect. Note that this bug only shows up when the socket
> owner is configured as a kernel module.
Acked-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
next prev parent reply other threads:[~2018-03-02 11:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 5:07 [PATCH v2 net] rds: Incorrect reference counting in TCP socket creation Ka-Cheong Poon
2018-03-02 6:22 ` santosh.shilimkar
2018-03-02 14:42 ` David Miller
2018-03-02 18:08 ` Santosh Shilimkar
2018-03-02 11:18 ` Sowmini Varadhan [this message]
2018-03-02 14:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180302111813.GA853@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=davem@davemloft.net \
--cc=ka-cheong.poon@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=santosh.shilimkar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).