From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f66.google.com ([74.125.83.66]:41366 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933990AbeCBVcU (ORCPT ); Fri, 2 Mar 2018 16:32:20 -0500 Received: by mail-pg0-f66.google.com with SMTP id q27so4277184pgn.8 for ; Fri, 02 Mar 2018 13:32:20 -0800 (PST) Date: Fri, 2 Mar 2018 13:32:11 -0800 From: Stephen Hemminger To: David Ahern Cc: u9012063@gmail.com, netdev@vger.kernel.org, chrism@mellanox.com Subject: Re: [PATCH iproute2] libnetlink: __rtnl_talk_iov should only loop max iovlen times Message-ID: <20180302133211.44d3e4f2@xeon-e3> In-Reply-To: <20180301224308.2629-1-dsahern@gmail.com> References: <20180301224308.2629-1-dsahern@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 1 Mar 2018 14:43:08 -0800 David Ahern wrote: > William reported ip hanging and bisected to a recent commit for batching > allowing more than 1 command to be sent per message. The loop over > recvmsg should never cycle more than iovlen times -- 1 response for > each command in the message. > > Fixes: 72a2ff3916e5 ("lib/libnetlink: Add a new function rtnl_talk_iov") > Signed-off-by: David Ahern > --- Applied