From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH net-next 1/5] net: mvpp2: use the same buffer pool for
 all ports
Date: Fri, 2 Mar 2018 17:01:59 +0100
Message-ID: <20180302170159.258bcdbc@windsurf.lan>
References: <20180302154044.25204-1-antoine.tenart@bootlin.com>
        <20180302154044.25204-2-antoine.tenart@bootlin.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: davem@davemloft.net, Stefan Chulski <stefanc@marvell.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        maxime.chevallier@bootlin.com, gregory.clement@bootlin.com,
        miquel.raynal@bootlin.com, nadavh@marvell.com,
        ymarkman@marvell.com, mw@semihalf.com
To: Antoine Tenart <antoine.tenart@bootlin.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20180302154044.25204-2-antoine.tenart@bootlin.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

Hello,

On Fri,  2 Mar 2018 16:40:40 +0100, Antoine Tenart wrote:
> +static struct {
> +	int pkt_size;
> +	int buf_num;
> +} mvpp2_pools[MVPP2_BM_POOLS_NUM];

Any reason for not doing:

} mvpp2_pools[MVPP2_BM_POOLS_NUM] = {
	[MVPP2_BM_SHORT] = {
		.pkt_size = MVPP2_BM_SHORT_PKT_SIZE,
		.buf_num = MVPP2_BM_SHORT_BUF_NUM
	},
	[MVPP2_BM_LONG] = {
		.pkt_size = MVPP2_BM_LONG_PKT_SIZE,
		.buf_num = MVPP2_BM_LONG_BUF_NUM,
	},
};

And get rid of:

> +static void mvpp2_setup_bm_pool(void)
> +{
> +	/* Short pool */
> +	mvpp2_pools[MVPP2_BM_SHORT].buf_num  = MVPP2_BM_SHORT_BUF_NUM;
> +	mvpp2_pools[MVPP2_BM_SHORT].pkt_size = MVPP2_BM_SHORT_PKT_SIZE;
> +
> +	/* Long pool */
> +	mvpp2_pools[MVPP2_BM_LONG].buf_num  = MVPP2_BM_LONG_BUF_NUM;
> +	mvpp2_pools[MVPP2_BM_LONG].pkt_size = MVPP2_BM_LONG_PKT_SIZE;
> +}

 ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com