From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: mst@redhat.com, virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
john.fastabend@gmail.com, brouer@redhat.com
Subject: Re: [PATCH net V2] virtio-net: re enable XDP_REDIRECT for mergeable buffer
Date: Fri, 2 Mar 2018 17:07:58 +0100 [thread overview]
Message-ID: <20180302170758.332600d6@redhat.com> (raw)
In-Reply-To: <1519982954-14360-1-git-send-email-jasowang@redhat.com>
On Fri, 2 Mar 2018 17:29:14 +0800
Jason Wang <jasowang@redhat.com> wrote:
> XDP_REDIRECT support for mergeable buffer was removed since commit
> 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable()
> case"). This is because we don't reserve enough tailroom for struct
> skb_shared_info which breaks XDP assumption. So this patch fixes this
> by reserving enough tailroom and using fixed size of rx buffer.
>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
> Changes from V1:
> - do not add duplicated tracepoint when redirection fails
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
I gave it a quick spin on my testlab, and cpumap seems to
work/not-crash now (if I managed to turn back config to
receive_mergeable() correctly ;-)).
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2018-03-02 16:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 9:29 [PATCH net V2] virtio-net: re enable XDP_REDIRECT for mergeable buffer Jason Wang
2018-03-02 16:07 ` Jesper Dangaard Brouer [this message]
2018-03-05 2:39 ` Jason Wang
2018-03-02 17:36 ` Michael S. Tsirkin
2018-03-05 2:41 ` Jason Wang
2018-03-04 23:38 ` David Miller
2018-03-05 2:43 ` Jason Wang
2018-03-05 3:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180302170758.332600d6@redhat.com \
--to=brouer@redhat.com \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).