From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from zimbra.alphalink.fr ([217.15.80.77]:51944 "EHLO
        zimbra.alphalink.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1946037AbeCBRna (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 2 Mar 2018 12:43:30 -0500
Date: Fri, 2 Mar 2018 18:43:28 +0100
From: Guillaume Nault <g.nault@alphalink.fr>
To: Denys Fedoryshchenko <nuclearcat@nuclearcat.com>
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
        Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: ppp/pppoe, still panic 4.15.3 in ppp_push
Message-ID: <20180302174328.GD1413@alphalink.fr>
References: <CAM_iQpXx=-YsKUtfOXv4zv+m7RjPgD3g1_L6_-vdBMLdekvHjQ@mail.gmail.com>
 <20180222183038.GD1322@alphalink.fr>
 <336f2012881f89f2b86b29a853c5a672@nuclearcat.com>
 <20180223093851.GE1322@alphalink.fr>
 <b702287ee6010632632e63605f24c4d0@nuclearcat.com>
 <20180223100710.GF1322@alphalink.fr>
 <a33df1f8aa456bbed7f0f67946ba0813@nuclearcat.com>
 <20180227185627.GI1322@alphalink.fr>
 <20180301200140.GC1413@alphalink.fr>
 <76c178cbb8e0514b1dac40b7f92d324e@nuclearcat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <76c178cbb8e0514b1dac40b7f92d324e@nuclearcat.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, Mar 01, 2018 at 10:07:05PM +0200, Denys Fedoryshchenko wrote:
> On 2018-03-01 22:01, Guillaume Nault wrote:
> > diff --git a/drivers/net/ppp/ppp_generic.c
> > b/drivers/net/ppp/ppp_generic.c
> > index 255a5def56e9..2acf4b0eabd1 100644
> > --- a/drivers/net/ppp/ppp_generic.c
> > +++ b/drivers/net/ppp/ppp_generic.c
> > @@ -3161,6 +3161,15 @@ ppp_connect_channel(struct channel *pch, int
> > unit)
> >  		goto outl;
> > 
> >  	ppp_lock(ppp);
> > +	spin_lock_bh(&pch->downl);
> > +	if (!pch->chan) {
> > +		/* Don't connect unregistered channels */
> > +		ppp_unlock(ppp);
> > +		spin_unlock_bh(&pch->downl);

This is obviously wrong. It should have been
+		spin_unlock_bh(&pch->downl);
+		ppp_unlock(ppp);

Sorry, I shouldn't have hurried.
This is fixed in the official version.

> > +		ret = -ENOTCONN;
> > +		goto outl;
> > +	}
> > +	spin_unlock_bh(&pch->downl);
> >  	if (pch->file.hdrlen > ppp->file.hdrlen)
> >  		ppp->file.hdrlen = pch->file.hdrlen;
> >  	hdrlen = pch->file.hdrlen + 2;	/* for protocol bytes */
> Ok, i will try to test that at night.
> Thanks a lot! For me also problem solved anyway by removing unit-cache, just
> i think it's nice to have bug fixed :)
> 
I think this bug has been there forever, indeed it's good to have it fixed.
Thanks a lot for your help (and patience!).

FYI, if you see accel-ppp logs like
"ioctl(PPPIOCCONNECT): Transport endpoint is not connected", then that
means the patch prevented the scenario that was leading to the original
crash.

Out of curiosity, did unit-cache really bring performance improvements
on your workload?