public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: intel-wired-lan@lists.osuosl.org
Cc: Vinicius Costa Gomes <vinicius.gomes@intel.com>,
	jeffrey.t.kirsher@intel.com, netdev@vger.kernel.org,
	jesus.sanchez-palencia@intel.com
Subject: [next-queue PATCH v2 1/8] igb: Fix not adding filter elements to the list
Date: Fri,  2 Mar 2018 10:43:37 -0800	[thread overview]
Message-ID: <20180302184344.5744-2-vinicius.gomes@intel.com> (raw)
In-Reply-To: <20180302184344.5744-1-vinicius.gomes@intel.com>

Because the order of the parameters passes to 'hlist_add_behind()' was
inverted, the 'parent' node was added "behind" the 'input', as input
is not in the list, this causes the 'input' node to be lost.

Fixes: 0e71def25281 ("igb: add support of RX network flow classification")
Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
---
 drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c
index 606e6761758f..143f0bb34e4d 100644
--- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
+++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
@@ -2864,7 +2864,7 @@ static int igb_update_ethtool_nfc_entry(struct igb_adapter *adapter,
 
 	/* add filter to the list */
 	if (parent)
-		hlist_add_behind(&parent->nfc_node, &input->nfc_node);
+		hlist_add_behind(&input->nfc_node, &parent->nfc_node);
 	else
 		hlist_add_head(&input->nfc_node, &adapter->nfc_filter_list);
 
-- 
2.16.2

  reply	other threads:[~2018-03-02 18:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-02 18:43 [next-queue PATCH v2 0/8] igb: offloading of receive filters Vinicius Costa Gomes
2018-03-02 18:43 ` Vinicius Costa Gomes [this message]
2018-03-02 18:43 ` [next-queue PATCH v2 2/8] igb: Fix queue selection on MAC filters on i210 and i211 Vinicius Costa Gomes
2018-03-02 18:43 ` [next-queue PATCH v2 3/8] igb: Enable the hardware traffic class feature bit for igb models Vinicius Costa Gomes
2018-03-02 18:43 ` [next-queue PATCH v2 4/8] igb: Add support for MAC address filters specifying source addresses Vinicius Costa Gomes
2018-03-02 18:43 ` [next-queue PATCH v2 5/8] igb: Enable nfc filters to specify MAC addresses Vinicius Costa Gomes
2018-03-02 18:43 ` [next-queue PATCH v2 6/8] igb: Add MAC address support for ethtool nftuple filters Vinicius Costa Gomes
2018-03-02 18:43 ` [next-queue PATCH v2 7/8] igb: Add the skeletons for tc-flower offloading Vinicius Costa Gomes
2018-03-02 18:43 ` [next-queue PATCH v2 8/8] igb: Add support for adding offloaded clsflower filters Vinicius Costa Gomes
2018-03-05 21:13   ` Jakub Kicinski
2018-03-06 19:08     ` Vinicius Costa Gomes
2018-03-06 19:28       ` Jakub Kicinski
2018-03-06 21:26         ` Vinicius Costa Gomes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180302184344.5744-2-vinicius.gomes@intel.com \
    --to=vinicius.gomes@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jesus.sanchez-palencia@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox