From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from vps0.lunn.ch ([185.16.172.187]:43938 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932386AbeCBUO3 (ORCPT ); Fri, 2 Mar 2018 15:14:29 -0500 Date: Fri, 2 Mar 2018 21:14:23 +0100 From: Andrew Lunn To: Bryan.Whitehead@microchip.com Cc: davem@davemloft.net, UNGLinuxDriver@microchip.com, netdev@vger.kernel.org Subject: Re: [PATCH v3 net-next 1/2] lan743x: Add main source files for new lan743x driver Message-ID: <20180302201423.GA25189@lunn.ch> References: <1519938009-10322-1-git-send-email-Bryan.Whitehead@microchip.com> <1519938009-10322-2-git-send-email-Bryan.Whitehead@microchip.com> <20180301221228.GD343@lunn.ch> <90A7E81AE28BAE4CBDDB3B35F187D2644071EFDF@CHN-SV-EXMX02.mchp-main.com> <20180302134042.GA19566@lunn.ch> <90A7E81AE28BAE4CBDDB3B35F187D2644071F1E3@CHN-SV-EXMX02.mchp-main.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <90A7E81AE28BAE4CBDDB3B35F187D2644071F1E3@CHN-SV-EXMX02.mchp-main.com> Sender: netdev-owner@vger.kernel.org List-ID: > Hi Andrew, > > The phy is built in for LAN7430, and external for LAN7431. But the > same reset should work in both cases because it asserts the normal > phy reset line. Assuming the PHY reset is connect to the external line, not a GPIO. So this is O.K. > > Assuming it is built in, does the MAC get the interrupt? > > phy_mac_interrupt() can be called if so. > > I believe the MAC does support a phy interrupt. But right now it's > working well using phy polling. Is it ok if I post pone supporting phy > interrupts until a future patch? I am planning a series of patches, and I > can add support for phy interrupts to the list. Yes, adding this later is fine. Andrew