From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f195.google.com ([209.85.216.195]:42423 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933412AbeCBVLi (ORCPT ); Fri, 2 Mar 2018 16:11:38 -0500 Received: by mail-qt0-f195.google.com with SMTP id t6so13590334qtn.9 for ; Fri, 02 Mar 2018 13:11:38 -0800 (PST) Date: Fri, 2 Mar 2018 18:11:19 -0300 From: Marcelo Ricardo Leitner To: Daniel Axtens Cc: netdev@vger.kernel.org Subject: Re: [PATCH v2 2/4] net: sched: tbf: handle GSO_BY_FRAGS case in enqueue Message-ID: <20180302211118.GG3887@localhost.localdomain> References: <20180301061340.15464-1-dja@axtens.net> <20180301061340.15464-3-dja@axtens.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180301061340.15464-3-dja@axtens.net> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Mar 01, 2018 at 05:13:38PM +1100, Daniel Axtens wrote: > tbf_enqueue() checks the size of a packet before enqueuing it. > However, the GSO size check does not consider the GSO_BY_FRAGS > case, and so will drop GSO SCTP packets, causing a massive drop > in throughput. > > Use skb_gso_validate_mac_len() instead, as it does consider that > case. > > Signed-off-by: Daniel Axtens Reviewed-by: Marcelo Ricardo Leitner > --- > net/sched/sch_tbf.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/sched/sch_tbf.c b/net/sched/sch_tbf.c > index 229172d509cc..03225a8df973 100644 > --- a/net/sched/sch_tbf.c > +++ b/net/sched/sch_tbf.c > @@ -188,7 +188,8 @@ static int tbf_enqueue(struct sk_buff *skb, struct Qdisc *sch, > int ret; > > if (qdisc_pkt_len(skb) > q->max_size) { > - if (skb_is_gso(skb) && skb_gso_mac_seglen(skb) <= q->max_size) > + if (skb_is_gso(skb) && > + skb_gso_validate_mac_len(skb, q->max_size)) > return tbf_segment(skb, sch, to_free); > return qdisc_drop(skb, sch, to_free); > } > -- > 2.14.1 >