From: Stefano Brivio <sbrivio@redhat.com>
To: Jean-Philippe Brucker <jphilippe.brucker@gmail.com>
Cc: stephen@networkplumber.org, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] ss: fix NULL dereference when rendering without header
Date: Sat, 3 Mar 2018 18:35:38 +0100 [thread overview]
Message-ID: <20180303183538.5d9f077b@epycfail> (raw)
In-Reply-To: <20180303165944.28102-1-jphilippe.brucker@gmail.com>
On Sat, 3 Mar 2018 16:59:44 +0000
Jean-Philippe Brucker <jphilippe.brucker@gmail.com> wrote:
> When ss is invoked with the no-header flag, if the query doesn't return
> any result, render() is called with 'buffer' uninitialized. This
> currently leads to a segfault. Ensure that buffer is initialized before
> rendering.
>
> The bug can be triggered with: ss -H sport = 100000
Oh dear. Nice catch, thanks for fixing this.
> Signed-off-by: Jean-Philippe Brucker <jphilippe.brucker@gmail.com>
Acked-by: Stefano Brivio <sbrivio@redhat.com>
--
Stefano
prev parent reply other threads:[~2018-03-03 17:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-03 16:59 [PATCH iproute2] ss: fix NULL dereference when rendering without header Jean-Philippe Brucker
2018-03-03 17:35 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180303183538.5d9f077b@epycfail \
--to=sbrivio@redhat.com \
--cc=jphilippe.brucker@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox