From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:48148 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752116AbeCCRgD (ORCPT ); Sat, 3 Mar 2018 12:36:03 -0500 Date: Sat, 3 Mar 2018 18:35:38 +0100 From: Stefano Brivio To: Jean-Philippe Brucker Cc: stephen@networkplumber.org, netdev@vger.kernel.org Subject: Re: [PATCH iproute2] ss: fix NULL dereference when rendering without header Message-ID: <20180303183538.5d9f077b@epycfail> In-Reply-To: <20180303165944.28102-1-jphilippe.brucker@gmail.com> References: <20180303165944.28102-1-jphilippe.brucker@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On Sat, 3 Mar 2018 16:59:44 +0000 Jean-Philippe Brucker wrote: > When ss is invoked with the no-header flag, if the query doesn't return > any result, render() is called with 'buffer' uninitialized. This > currently leads to a segfault. Ensure that buffer is initialized before > rendering. > > The bug can be triggered with: ss -H sport = 100000 Oh dear. Nice catch, thanks for fixing this. > Signed-off-by: Jean-Philippe Brucker Acked-by: Stefano Brivio -- Stefano