From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:42580 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751692AbeCDSEt (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sun, 4 Mar 2018 13:04:49 -0500
Date: Sun, 04 Mar 2018 13:04:47 -0500 (EST)
Message-Id: <20180304.130447.1143332997237734699.davem@davemloft.net>
To: dsahern@gmail.com
Cc: netdev@vger.kernel.org, idosch@idosch.org,
        roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com,
        tom@herbertland.com
Subject: Re: [PATCH v3 net-next 00/10] net/ipv6: Add support for path
 selection using hash of 5-tuple
From: David Miller <davem@davemloft.net>
In-Reply-To: <20180302163221.26954-1-dsahern@gmail.com>
References: <20180302163221.26954-1-dsahern@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: David Ahern <dsahern@gmail.com>
Date: Fri,  2 Mar 2018 08:32:11 -0800

> Hardware supports multipath selection using the standard L4 5-tuple
> instead of just L3 and the flow label. In addition, some network
> operators prefer IPv6 path selection to use the 5-tuple. To that end,
> add support to IPv6 for multipath hash policy similar to
> bf4e0a3db97eb ("net: ipv4: add support for ECMP hash policy choice").
> The default is still L3 which covers source and destination addresses
> along with flow label and IPv6 protocol. This gives users a choice in
> hash algorithms if they believe L3 only and the IPv6 flow label are not
> sufficient for their use case.
> 
> A separate sysctl is added for IPv6, allowing IPv4 and IPv6 to use
> different algorithms if desired.
> 
> The first 3 patches modify the IPv4 variant so that at the end of the
> patch set the ipv4 and ipv6 implementations are direct parallels.
> 
> Patch 4 refactors the existing rt6_multipath_hash in preparation for
> adding the policy option.
> 
> Patch 5 renames the existing netevent to have IPv4 in the name so ipv4
> changes can be distinguished from IPv6 if the netevent handler cares.
> 
> Patch 6 adds the skb as an argument through the FIB lookup functions
> to the multipath selection. Needed for the forwarding case.
> 
> Patch 7 adds the L4 hash support.
> 
> Patch 8 adds the hook for the netevent to the spectrum driver to update
> the ASIC.
> 
> Patch 9 removes no longer used code.
> 
> Patch 10 adds a testcase for IPv6 multipath with L4 hash.
 ...

Series applied, nice work David.