From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:42888 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932080AbeCDScx (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sun, 4 Mar 2018 13:32:53 -0500
Date: Sun, 04 Mar 2018 13:32:52 -0500 (EST)
Message-Id: <20180304.133252.1534424371008542744.davem@davemloft.net>
To: akurz@blala.de
Cc: afd@ti.com, linux-usb@vger.kernel.org, netdev@vger.kernel.org,
        freddy@asix.com.tw
Subject: Re: [PATCH 2/2] net: usb: asix88179_178a: de-duplicate code
From: David Miller <davem@davemloft.net>
In-Reply-To: <20180228212739.5460-2-akurz@blala.de>
References: <20180228212739.5460-1-akurz@blala.de>
        <20180228212739.5460-2-akurz@blala.de>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Alexander Kurz <akurz@blala.de>
Date: Wed, 28 Feb 2018 21:27:39 +0000

> -static int ax88179_bind(struct usbnet *dev, struct usb_interface *intf)
> +static int ax88179_link_bind_or_reset(struct usbnet *dev, int do_reset)

"do_reset" is a boolean, therefore please use type 'bool' and true/false.

Thank you.