From: David Miller <davem@davemloft.net>
To: atul.gupta@chelsio.com
Cc: davejwatson@fb.com, herbert@gondor.apana.org.au,
linux-crypto@vger.kernel.org, netdev@vger.kernel.org,
ganeshgr@chelsio.com
Subject: Re: [crypto v8 04/12] chtls: structure and macro definiton
Date: Sun, 04 Mar 2018 14:45:10 -0500 (EST) [thread overview]
Message-ID: <20180304.144510.551985522332604984.davem@davemloft.net> (raw)
In-Reply-To: <1519883383-4911-4-git-send-email-atul.gupta@chelsio.com>
From: Atul Gupta <atul.gupta@chelsio.com>
Date: Thu, 1 Mar 2018 11:19:35 +0530
> + __u8 reneg_to_write_rx;
> + __u8 protocol;
You should use "u8" rather than "__u8" except in UAPI headers
which this file is not.
Please audit your entire patch series for this issue.
Thank you.
next prev parent reply other threads:[~2018-03-04 19:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 5:49 [crypto v8 01/12] tls: tls_device struct to register TLS drivers Atul Gupta
2018-03-01 5:49 ` [crypto v8 02/12] ethtool: enable Inline TLS in HW Atul Gupta
2018-03-01 5:49 ` [crypto v8 03/12] tls: support for inline tls Atul Gupta
2018-03-01 5:49 ` [crypto v8 04/12] chtls: structure and macro definiton Atul Gupta
2018-03-04 19:45 ` David Miller [this message]
2018-03-01 5:49 ` [crypto v8 05/12] cxgb4: Inline TLS FW Interface Atul Gupta
2018-03-01 5:49 ` [crypto v8 06/12] cxgb4: LLD driver changes to enable TLS Atul Gupta
2018-03-01 5:49 ` [crypto v8 07/12] chcr: Key Macro Atul Gupta
2018-03-01 5:49 ` [crypto v8 08/12] chtls: Key program Atul Gupta
2018-03-01 5:49 ` [crypto v8 09/12] chtls: CPL handler definition Atul Gupta
2018-03-01 5:49 ` [crypto v8 10/12] chtls: Inline crypto request Tx/Rx Atul Gupta
2018-03-01 5:49 ` [crypto v8 11/12] chtls: Register chtls Inline TLS with net tls Atul Gupta
2018-03-01 5:49 ` [crypto v8 12/12] Makefile Kconfig Atul Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180304.144510.551985522332604984.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=atul.gupta@chelsio.com \
--cc=davejwatson@fb.com \
--cc=ganeshgr@chelsio.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).