From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:43602 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751899AbeCDTpO (ORCPT ); Sun, 4 Mar 2018 14:45:14 -0500 Date: Sun, 04 Mar 2018 14:45:10 -0500 (EST) Message-Id: <20180304.144510.551985522332604984.davem@davemloft.net> To: atul.gupta@chelsio.com Cc: davejwatson@fb.com, herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org, netdev@vger.kernel.org, ganeshgr@chelsio.com Subject: Re: [crypto v8 04/12] chtls: structure and macro definiton From: David Miller In-Reply-To: <1519883383-4911-4-git-send-email-atul.gupta@chelsio.com> References: <1519883383-4911-1-git-send-email-atul.gupta@chelsio.com> <1519883383-4911-4-git-send-email-atul.gupta@chelsio.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: Atul Gupta Date: Thu, 1 Mar 2018 11:19:35 +0530 > + __u8 reneg_to_write_rx; > + __u8 protocol; You should use "u8" rather than "__u8" except in UAPI headers which this file is not. Please audit your entire patch series for this issue. Thank you.