From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f41.google.com ([74.125.83.41]:45773 "EHLO mail-pg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751962AbeCDQ6s (ORCPT ); Sun, 4 Mar 2018 11:58:48 -0500 Received: by mail-pg0-f41.google.com with SMTP id i133so5872677pgc.12 for ; Sun, 04 Mar 2018 08:58:47 -0800 (PST) Date: Sun, 4 Mar 2018 08:58:42 -0800 From: Stephen Hemminger To: David Kaufmann Cc: netdev@vger.kernel.org Subject: Re: lnstat Message-ID: <20180304085842.2e8505e8@xeon-e3> In-Reply-To: <20180303215602.fh6tp5na2emvmdvz@anduin> References: <20180303215602.fh6tp5na2emvmdvz@anduin> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/fCX4L=8p+HrCC9GVymL4EL/"; protocol="application/pgp-signature" Sender: netdev-owner@vger.kernel.org List-ID: --Sig_/fCX4L=8p+HrCC9GVymL4EL/ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sat, 3 Mar 2018 22:56:02 +0100 David Kaufmann wrote: > Hi! >=20 > `lnstat` segfaults (tested on Debian 9, CentOS 6+7, Fedora 27) if it is > started as `lnstat -w 1` >=20 > according to gdb the crash is in `build_hdr_string` at lnstat.c:212 >=20 > as it seems to be an useless value for the option anyway it might make > sense to just handle a single "1" the same as if "0" was specified. > `-w 0,1`, `-w 1,0`, `-w 1,1` and other variations do work. Right having one character width is breaking the header building code. Probably should just catch it in the option parsing. >=20 > All the best, > Astra >=20 > PS: I did not find any other place to report this, if this is the wrong > place please tell we where to post. This the right place. --Sig_/fCX4L=8p+HrCC9GVymL4EL/ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEn2/DRbBb5+dmuDyPgKd/YJXN5H4FAlqcJcIACgkQgKd/YJXN 5H4OZhAAjfUjV7Rxnye3+xZwtVAkMem7I4fUBHy0xJMD8q8dGG0V5EaEHEuOTUA9 NKGPNbCLdnHoOwoeK9TGNcdO6iJxDt9uYLcGPzsh6dT5OBzMKJi+uXnEbasnU1jy UWWXVX8uVUjQz7T4irgyqp1jh7wMzPZExxs7gMOK2BeA0yoV4J1EPF0ZMs1iFVFq FKHIMktaWgPPBTz4WY0AOjKlQl1pQ0CWSRtHXr1H4mINWycxdHbBI7QLrmBeypJD fibelcaTnANigY/K0xH7IxYI9+DCzfymEMXCl3TUNNk6yyrDO+GOvnWHUfVm608m zL6zgmamhLUwzROdr5XbvxGp499v5POl94xeNc524xLAKYNFyD3GwNjBolrtXhMW W9AgvbqXpIFyBSOEz1cQOyk8jQ+qpc2Q+Lm71lMkfkdO110Jrqh2mNr9GsTCzM+q IKKH6sDbd+LjFdzqNnovExgYachv+jGxx+n2oa9GKDDEYcm3pKy/KiiKmm2Y62IP oIC5WE3yj0vG+bm62zaxEx2DHPBOr49WG9H6pX9qP3FQGKzfZEFrmvSZqM60UGpE eejdY7BPZMn+5p5i6E9X0wZvTb4jpEf05kS4Qp7jzSku/CZADAtMsb9YFTmwDaa7 6wr+12WfGn0h0BHZ8qhMzLeseddWGaEbWD8q6CyMs1sLd7LfB1o= =HoVV -----END PGP SIGNATURE----- --Sig_/fCX4L=8p+HrCC9GVymL4EL/--