From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f67.google.com ([74.125.83.67]:35840 "EHLO
        mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751962AbeCDRB5 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sun, 4 Mar 2018 12:01:57 -0500
Received: by mail-pg0-f67.google.com with SMTP id i14so5890769pgv.3
        for <netdev@vger.kernel.org>; Sun, 04 Mar 2018 09:01:57 -0800 (PST)
Date: Sun, 4 Mar 2018 09:01:54 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Davide Caratti <dcaratti@redhat.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>,
        Jiri Pirko <jiri@mellanox.com>, netdev@vger.kernel.org,
        Wolfgang Bumiller <w.bumiller@proxmox.com>,
        Michal Privoznik <mprivozn@redhat.com>
Subject: Re: [PATCH iproute2] tc: fix parsing of the control action
Message-ID: <20180304090154.1b36d04b@xeon-e3>
In-Reply-To: <59b3a21ecf0c79dcc7cade919ff00f1f0ee73b31.1520015432.git.dcaratti@redhat.com>
References: <59b3a21ecf0c79dcc7cade919ff00f1f0ee73b31.1520015432.git.dcaratti@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri,  2 Mar 2018 19:36:16 +0100
Davide Caratti <dcaratti@redhat.com> wrote:

> If the user didn't specify any control action, don't pop the command line
> arguments: otherwise, parsing of the next argument (tipically the 'index'
> keyword) results in an error, causing the following 'tc-testing' failures:
> 
>  Test a6d6: Add skbedit action with index
>  Test 38f3: Delete skbedit action
>  Test a568: Add action with ife type
>  Test b983: Add action without ife type
>  Test 7d50: Add skbmod action to set destination mac
>  Test 9b29: Add skbmod action to set source mac
>  Test e93a: Delete an skbmod action
> 
> Also, add missing parse for 'ok' control action to m_police, to fix the
> following 'tc-testing' failure:
> 
>  Test 8dd5: Add police action with control ok
> 
> tested with:
>  # ./tdc.py
> 
> test results:
>  all tests ok using kernel 4.16-rc2, except 9aa8 "Get a single skbmod
>  action from a list" (which is failing also before this commit)
> 
> Fixes: 3572e01a090a ("tc: util: Don't call NEXT_ARG_FWD() in __parse_action_control()")
> Cc: Michal Privoznik <mprivozn@redhat.com>
> Cc: Wolfgang Bumiller <w.bumiller@proxmox.com>
> Signed-off-by: Davide Caratti <dcaratti@redhat.com>
> ---

Applied thanks.