Re: dsa with 2 rgmii channels (1st is 2 switches & 2nd is phy)

[Andrew Lunn <andrew@lunn.ch>]

Hi Michael

>                 mdio {
>                                 compatible = "cdns,macb-mdio";
> /*                           reg = <0xe000b000 0x1000>; */
> /*                           clocks = <&clkc 30>, <&clkc 30>, <&clkc 13>; */
> /*                           clock-names = "pclk", "hclk", "tx_clk"; */
>                                 #address-cells = <1>;
>                                 #size-cells = <0>;
>                                 status = "okay";
>                                 switch0: switch@0 {
>                                                 compatible = "marvell,mv88e6352";

Please use marvell,mv88e6085. That is what the 6352 is compatible
with.

It would also be good to sort out your mixup between tabs and spaces.

>                 mdio {
>                                 compatible = "cdns,macb-mdio";
> /*                           reg = <0xe000c000 0x1000>; */
> /*                           clocks = <&clkc 31>, <&clkc 31>, <&clkc 14>; */
> /*                           clock-names = "pclk", "hclk", "tx_clk"; */
>                                 #address-cells = <1>;
>                                 #size-cells = <0>;
>                                 status = "okay";
>                                 ethernet_phy: ethernet-phy@0 {
>                                                 compatible = "marvell,mv88e1510";
>                                                 device_type = "ethernet-phy";
>                                                 reg = <0>;
>                                 };

PHYs don't have compatible strings. It is not needed, you can read the
vendor and model from its registers.

       Andrew