From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:52950 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751342AbeCEOO2 (ORCPT ); Mon, 5 Mar 2018 09:14:28 -0500 Date: Mon, 05 Mar 2018 09:14:16 -0500 (EST) Message-Id: <20180305.091416.1776596186715120504.davem@davemloft.net> To: sbrivio@redhat.com Cc: dsahern@gmail.com, weiwan@google.com, yoshfuji@linux-ipv6.org, maze@google.com, netdev@vger.kernel.org Subject: Re: [PATCH net] ipv6: Reflect MTU changes on PMTU of exceptions for MTU-less routes From: David Miller In-Reply-To: <20180305132956.1495e819@epycfail> References: <20180305001245.23b56b3f@epycfail> <20180305132956.1495e819@epycfail> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: Stefano Brivio Date: Mon, 5 Mar 2018 13:29:56 +0100 > And about corner cases, from Documentation/dev-tools/kselftest.rst: > > These are intended to be small tests to exercise individual code > paths in the kernel. Tests are intended to be run after building, installing > and booting a kernel. > > and: > > In general, the rules for selftests are > [...] > * Don't take too long; > > if you plan to request a self-test for every fix in the networking area, > you need to substantially change the scope of these self-tests. This stuff > would instead fit in a comprehensive networking test suite. Nice try, but this logic doesn't hold. It says don't make any "_INDIVIDUAL_" test take too long to run. This allows handling timeouts on individual tests more sanely. It absolutely does not say that we shouldn't have a lot of tests. Why are you working so hard to avoid adding a nice test case for the bug you are fixing? This makes absolultely not sense at all. I want as many tests as possible for the networking code, so please write the test case you are being requested to add. Thank you.