From: David Miller <davem@davemloft.net>
To: felix.manlunas@cavium.com
Cc: netdev@vger.kernel.org, raghu.vatsavayi@cavium.com,
derek.chickles@cavium.com, satananda.burla@cavium.com,
intiyaz.basha@cavium.com
Subject: Re: [PATCH net-next] liquidio: Added ndo_get_phys_port_id support
Date: Mon, 05 Mar 2018 10:23:39 -0500 (EST) [thread overview]
Message-ID: <20180305.102339.1643465658148939503.davem@davemloft.net> (raw)
In-Reply-To: <20180303025910.GA26255@felix-thinkpad.cavium.com>
From: Felix Manlunas <felix.manlunas@cavium.com>
Date: Fri, 2 Mar 2018 18:59:10 -0800
> Added support to the ndo_get_phys_port_id() callback to provide
> port specific unique id to the netdev layer.
>
> Port id needs to be unique across different liquidio devices in the system.
> So used MAC address for port_id.
This doesn't look right at all.
The physical port ID is used in order to distinguish several netdev
devices present on the same PHYSICAL PORT.
So you should be using a number that is unique within a physical
port.
Using the MAC address for this doesn't make any sense at all.
prev parent reply other threads:[~2018-03-05 15:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-03 2:59 [PATCH net-next] liquidio: Added ndo_get_phys_port_id support Felix Manlunas
2018-03-05 15:23 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180305.102339.1643465658148939503.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=derek.chickles@cavium.com \
--cc=felix.manlunas@cavium.com \
--cc=intiyaz.basha@cavium.com \
--cc=netdev@vger.kernel.org \
--cc=raghu.vatsavayi@cavium.com \
--cc=satananda.burla@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).