From: David Miller <davem@davemloft.net>
To: j.neuschaefer@gmx.net
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/3] net: core: dst_cache_set_ip6: Rename 'addr' parameter to 'saddr' for consistency
Date: Mon, 05 Mar 2018 12:53:10 -0500 (EST) [thread overview]
Message-ID: <20180305.125310.1977914248766873754.davem@davemloft.net> (raw)
In-Reply-To: <20180304022953.4508-2-j.neuschaefer@gmx.net>
From: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Date: Sun, 4 Mar 2018 03:29:52 +0100
> The other dst_cache_{get,set}_ip{4,6} functions, and the doc comment for
> dst_cache_set_ip6 use 'saddr' for their source address parameter. Rename
> the parameter to increase consistency.
>
> This fixes the following kernel-doc warnings:
>
> ./include/net/dst_cache.h:58: warning: Function parameter or member 'addr' not described in 'dst_cache_set_ip6'
> ./include/net/dst_cache.h:58: warning: Excess function parameter 'saddr' description in 'dst_cache_set_ip6'
>
> Fixes: 911362c70df5 ("net: add dst_cache support")
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Applied to net-next.
next prev parent reply other threads:[~2018-03-05 17:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-04 2:29 [PATCH 1/3] net: core: dst_cache: Fix a typo in a comment Jonathan Neuschäfer
2018-03-04 2:29 ` [PATCH 2/3] net: core: dst_cache_set_ip6: Rename 'addr' parameter to 'saddr' for consistency Jonathan Neuschäfer
2018-03-05 17:53 ` David Miller [this message]
2018-03-04 2:29 ` [PATCH 3/3] net: core: dst: Add kernel-doc for 'net' parameter Jonathan Neuschäfer
2018-03-05 17:53 ` David Miller
2018-03-05 17:53 ` [PATCH 1/3] net: core: dst_cache: Fix a typo in a comment David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180305.125310.1977914248766873754.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=j.neuschaefer@gmx.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).