From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:57718 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752953AbeCEVUs (ORCPT ); Mon, 5 Mar 2018 16:20:48 -0500 Date: Mon, 05 Mar 2018 16:20:40 -0500 (EST) Message-Id: <20180305.162040.1738604452489890352.davem@davemloft.net> To: jeffrey.t.kirsher@intel.com Cc: eric.dumazet@gmail.com, pkerbrat@kalray.eu, netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com, jogreene@redhat.com, mgligor@kalray.eu Subject: Re: [net-next 4/4] e1000e: allocate ring descriptors with dma_zalloc_coherent From: David Miller In-Reply-To: <1520276969.5010.2.camel@intel.com> References: <20180305181631.3872-5-jeffrey.t.kirsher@intel.com> <1520274223.109662.8.camel@gmail.com> <1520276969.5010.2.camel@intel.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: Jeff Kirsher Date: Mon, 05 Mar 2018 11:09:29 -0800 > On Mon, 2018-03-05 at 10:23 -0800, Eric Dumazet wrote: >> On Mon, 2018-03-05 at 10:16 -0800, Jeff Kirsher wrote: >> > From: Pierre-Yves Kerbrat >> > >> > Descriptor rings were not initialized at zero when allocated >> > When area contained garbage data, it caused skb_over_panic in >> > e1000_clean_rx_irq (if data had E1000_RXD_STAT_DD bit set) >> > >> > This patch makes use of dma_zalloc_coherent to make sure the >> > ring is memset at 0 to prevent the area from containing garbage. >> > >> >> This looks like a net candidate, fixing a bug, with 0 chance adding a >> regression IMO. > > I am fine with that. Dave, let me know if you want me to re-submit > this change for net/stable. Yes, please add this patch to the net-queue pull request you also sent today. Thanks.