From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mx3-rdu2.redhat.com ([66.187.233.73]:44394 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S932524AbeCDXMw (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sun, 4 Mar 2018 18:12:52 -0500
Date: Mon, 5 Mar 2018 00:12:45 +0100
From: Stefano Brivio <sbrivio@redhat.com>
To: David Ahern <dsahern@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
        Wei Wang <weiwan@google.com>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        Maciej =?UTF-8?B?xbtlbmN6?= =?UTF-8?B?eWtvd3NraQ==?=
        <maze@google.com>, netdev@vger.kernel.org
Subject: Re: [PATCH net] ipv6: Reflect MTU changes on PMTU of exceptions for
 MTU-less routes
Message-ID: <20180305001245.23b56b3f@epycfail>
In-Reply-To: <20180303122236.6dde3a9b@epycfail>
References: <81bfe26bed31319d765a4ebfe86705a49c0a39d5.1520003901.git.sbrivio@redhat.com>
        <84593e49-357b-818c-79c5-d265d8c32b03@gmail.com>
        <20180303122236.6dde3a9b@epycfail>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Sat, 3 Mar 2018 12:22:36 +0100
Stefano Brivio <sbrivio@redhat.com> wrote:

> > And please codify the above expectation as a test under
> > tools/testing/selftests/net  
> 
> And this, along with v2.

On a second thought: I start thinking it doesn't make much sense,
especially given the current context of self-tests, to explicitly test
this, because it's a rather particular corner case.

I think it would make more sense to introduce generic tests first.
About, say, PMTU, or route exceptions, but not "tunnel causes route
exception and administrative change doesn't affect PMTU".

-- 
Stefano