From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arushi Singhal Subject: [PATCH v3] staging: ipx: Replace printk() with appropriate net_*macro_ratelimited() Date: Mon, 5 Mar 2018 09:47:40 +0530 Message-ID: <20180305041740.GA23378@seema-Inspiron-15-3567> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com To: gregkh@linuxfoundation.org Return-path: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" List-Id: netdev.vger.kernel.org Replace printk having a log level with the appropriate net_*macro_ratelimited. It's better to use actual device name as a prefix in error messages. Signed-off-by: Arushi Singhal --- changes in v2 *In v1 printk was changed to pr_*macro(), which is used in kernel instead of calling printk() directly. And for drivers, dev_*macro() or net_*macro_ratelimited() should be used for calling printk() directly. changes in v3 *Indentation is not changed, as line is exceeding 80 characters limit. drivers/staging/ipx/af_ipx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ipx/af_ipx.c b/drivers/staging/ipx/af_ipx.c index d21a9d1..5ec6591 100644 --- a/drivers/staging/ipx/af_ipx.c +++ b/drivers/staging/ipx/af_ipx.c @@ -744,7 +744,7 @@ static void ipxitf_discover_netnum(struct ipx_interface *intrfc, intrfc->if_netnum = cb->ipx_source_net; ipxitf_add_local_route(intrfc); } else { - printk(KERN_WARNING "IPX: Network number collision " + net_warn_ratelimited("IPX: Network number collision " "%lx\n %s %s and %s %s\n", (unsigned long) ntohl(cb->ipx_source_net), ipx_device_name(i), -- 2.7.4