From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:45046 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933485AbeCEJlc (ORCPT ); Mon, 5 Mar 2018 04:41:32 -0500 Date: Mon, 5 Mar 2018 11:41:28 +0200 From: Leon Romanovsky To: Michal Kalderon Cc: davem@davemloft.net, netdev@vger.kernel.org, dledford@redhat.com, jgg@mellanox.com, linux-rdma@vger.kernel.org, Ariel Elior Subject: Re: [PATCH net] qed: Free RoCE ILT Memory on rmmod qedr Message-ID: <20180305094128.GI15340@mtr-leonro.local> References: <1520240651-11308-1-git-send-email-Michal.Kalderon@cavium.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="B8ONY/mu/bqBak9m" Content-Disposition: inline In-Reply-To: <1520240651-11308-1-git-send-email-Michal.Kalderon@cavium.com> Sender: netdev-owner@vger.kernel.org List-ID: --B8ONY/mu/bqBak9m Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Mar 05, 2018 at 11:04:11AM +0200, Michal Kalderon wrote: > Rdma requires ILT Memory to be allocated for it's QPs. > Each ILT entry points to a page used by several Rdma QPs. > To avoid allocating all the memory in advance, the rdma > implementation dynamically allocates memory as more QPs are > added, however it does not dynamically free the memory. > The memory should have been freed on rmmod qedr, but isn't. > This patch adds the memory freeing on rmmod qedr (currently > it will be freed with qed is removed). > > An outcome of this bug, is that if qedr is unloaded and loaded > without unloaded qed, there will be no more RoCE traffic. > > The reason these are related, is that the logic of detecting the > first QP ever opened is by asking whether ILT memory for RoCE has > been allocated. > > In addition, this patch modifies freeing of the Task context to > always use the PROTOCOLID_ROCE and not the protocol passed, > this is because task context for iWARP and ROCE both use the > ROCE protocol id, as opposed to the connection context. > > Fixes: dbb799c39717e7b7 Your fixes line was truncated. Thanks --B8ONY/mu/bqBak9m Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAlqdEMgACgkQ5GN7iDZy WKe9RA//VhqQY6a+rqZyDvWumPlrVlT9+nYVhh+Awp4eazWee2t4MNI3eNP8Opz4 rKhRpyAJptEM3gYJzGUOSPwB3ZiUh5OpKD/usBLxrPRr4tPvbirABqxUXzD00xMp Iz9PBaSQX4XQO28YxUVuVFuz9u5QZTh04uR1918VLRe84yO/NeOD+dPRodNmC+Ms uDSapgEIIB+avHbmYXCePceQaGv9uCneic/7RxicCqmpMn3F/Xkq+TUlGP+jSoMg oGLpQSduagl/t7tSBTkBLnbY5JZTBxD4qFjpkPGSxb17KsiUACYqVtRgEXhBSt8t pPNvCjKWJ72NoaBtw9/Ky1mrrcpi1RSilpyNj2HDZ5gNexF/FfgqtIba0urPzGHN 1VQHzsccP0V0tOjhYQfNZdsu2SrfqCKis8yQXiSMB/HhE56dtmxoNc3C2UF8EjRA zZrPH/zylrkj1AtIGb3H8POE7ret+xExsMFF40hfgsInpETiDXF5D9f6bjING+jR dUp3+Nw5FqtKHkXf7If9Z1/8lHZwkUo8nADY5+7B2In15c2Xos7D586folBL3guX tt+5/4OHE6zywzQFkI3HhZSTZzZRjoPmS5QQ/JuA12w/lO0rfCBAR5a3dZ7n5G2J v6Oltt8vkrUVTy88OYiJg4+hBYN3upQybUjonU3AC+/I4Dl9vxw= =LW/m -----END PGP SIGNATURE----- --B8ONY/mu/bqBak9m--