From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:43394 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753504AbeCFVlk (ORCPT ); Tue, 6 Mar 2018 16:41:40 -0500 Date: Tue, 06 Mar 2018 16:41:37 -0500 (EST) Message-Id: <20180306.164137.1449749449273628774.davem@davemloft.net> To: dsahern@gmail.com Cc: netdev@vger.kernel.org Subject: Re: [PATCH net-next] net: Only honor ifindex in IP_PKTINFO if non-0 From: David Miller In-Reply-To: <7bfc59d2-ea74-0962-67a5-9c5adc8b9e8f@gmail.com> References: <20180216190303.30769-1-dsahern@gmail.com> <7bfc59d2-ea74-0962-67a5-9c5adc8b9e8f@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: David Ahern Date: Tue, 6 Mar 2018 13:52:05 -0700 > On 2/16/18 12:03 PM, David Ahern wrote: >> Only allow ifindex from IP_PKTINFO to override SO_BINDTODEVICE settings >> if the index is actually set in the message. >> >> Signed-off-by: David Ahern >> --- >> net/ipv4/ip_sockglue.c | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> > > Dave: Any chance this can get backported to 4.14 and 4.9 stable > releases? Right now, net-snmp is dead in the water with VRF because it > uses IP_PKTINFO to set the source address AND in the process sets the > ifindex to 0 to allow asymmetric routing (request received on one > interface and response goes out a different one). This patch allows 'ip > vrf exec mgmt snmpd' to work. Ok, I've put this patch into 'net' and will let it soak there, and also queue it up for a future -stable submission. Thanks David.