* [RFC PATCH linux-next] net: mvpp2: mvpp2_check_hw_buf_num() can be static
2018-03-06 5:05 [linux-next:master 5332/5518] drivers/net/ethernet/marvell/mvpp2.c:4288:5: sparse: symbol 'mvpp2_check_hw_buf_num' was not declared. Should it be static? kbuild test robot
@ 2018-03-06 5:05 ` kbuild test robot
2018-03-07 17:23 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2018-03-06 5:05 UTC (permalink / raw)
To: Stefan Chulski
Cc: kbuild-all, Antoine Tenart, Thomas Petazzoni, Markus Elfring,
Maxime Chevallier, Miquel Raynal, Marcin Wojtas, netdev,
linux-kernel
Fixes: effbf5f58d64 ("net: mvpp2: update the BM buffer free/destroy logic")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
mvpp2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c
index c7b8093..c360430 100644
--- a/drivers/net/ethernet/marvell/mvpp2.c
+++ b/drivers/net/ethernet/marvell/mvpp2.c
@@ -4285,7 +4285,7 @@ static void mvpp2_bm_bufs_free(struct device *dev, struct mvpp2 *priv,
}
/* Check number of buffers in BM pool */
-int mvpp2_check_hw_buf_num(struct mvpp2 *priv, struct mvpp2_bm_pool *bm_pool)
+static int mvpp2_check_hw_buf_num(struct mvpp2 *priv, struct mvpp2_bm_pool *bm_pool)
{
int buf_num = 0;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [linux-next:master 5332/5518] drivers/net/ethernet/marvell/mvpp2.c:4288:5: sparse: symbol 'mvpp2_check_hw_buf_num' was not declared. Should it be static?
@ 2018-03-06 5:05 kbuild test robot
2018-03-06 5:05 ` [RFC PATCH linux-next] net: mvpp2: mvpp2_check_hw_buf_num() can be static kbuild test robot
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2018-03-06 5:05 UTC (permalink / raw)
To: Stefan Chulski
Cc: kbuild-all, Antoine Tenart, Thomas Petazzoni, Markus Elfring,
Maxime Chevallier, Miquel Raynal, Marcin Wojtas, netdev,
linux-kernel
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 9c142d8a6556f069be6278ccab701039da81ad6f
commit: effbf5f58d64b1d1f93cb687d9797b42f291d5fd [5332/5518] net: mvpp2: update the BM buffer free/destroy logic
reproduce:
# apt-get install sparse
git checkout effbf5f58d64b1d1f93cb687d9797b42f291d5fd
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> drivers/net/ethernet/marvell/mvpp2.c:4288:5: sparse: symbol 'mvpp2_check_hw_buf_num' was not declared. Should it be static?
drivers/net/ethernet/marvell/mvpp2.c:6620:36: sparse: incorrect type in argument 2 (different base types) @@ expected int [signed] l3_proto @@ got restricted __be1int [signed] l3_proto @@
drivers/net/ethernet/marvell/mvpp2.c:6620:36: expected int [signed] l3_proto
drivers/net/ethernet/marvell/mvpp2.c:6620:36: got restricted __be16 [usertype] protocol
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC PATCH linux-next] net: mvpp2: mvpp2_check_hw_buf_num() can be static
2018-03-06 5:05 ` [RFC PATCH linux-next] net: mvpp2: mvpp2_check_hw_buf_num() can be static kbuild test robot
@ 2018-03-07 17:23 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2018-03-07 17:23 UTC (permalink / raw)
To: fengguang.wu
Cc: stefanc, kbuild-all, antoine.tenart, thomas.petazzoni, elfring,
maxime.chevallier, miquel.raynal, mw, netdev, linux-kernel
From: kbuild test robot <fengguang.wu@intel.com>
Date: Tue, 6 Mar 2018 13:05:06 +0800
> Fixes: effbf5f58d64 ("net: mvpp2: update the BM buffer free/destroy logic")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-07 17:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-06 5:05 [linux-next:master 5332/5518] drivers/net/ethernet/marvell/mvpp2.c:4288:5: sparse: symbol 'mvpp2_check_hw_buf_num' was not declared. Should it be static? kbuild test robot
2018-03-06 5:05 ` [RFC PATCH linux-next] net: mvpp2: mvpp2_check_hw_buf_num() can be static kbuild test robot
2018-03-07 17:23 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).