From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v2] staging: Replace printk() with appropriate net_*macro_ratelimited() Date: Tue, 6 Mar 2018 03:59:35 -0800 Message-ID: <20180306115935.GA17888@kroah.com> References: <20180304204910.GA4840@seema-Inspiron-15-3567> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com To: Arushi Singhal Return-path: Content-Disposition: inline In-Reply-To: <20180304204910.GA4840@seema-Inspiron-15-3567> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" List-Id: netdev.vger.kernel.org On Mon, Mar 05, 2018 at 02:19:11AM +0530, Arushi Singhal wrote: > Replace printk having a log level with the appropriate > net_*macro_ratelimited. > It's better to use actual device name as a prefix in error messages. > Indentation is also changed, to fix the checkpatch issue. > > Signed-off-by: Arushi Singhal > --- > changes in v2 > *In previous version printk was changed to pr_*macro(), which is used > in kernel instead of calling printk() directly. And for drivers, > dev_*macro() or net_*macro_ratelimited() should be used for calling > printk() directly. > > drivers/staging/ipx/af_ipx.c | 14 +++++++------- Please read drivers/staging/ipx/TODO thanks, greg k-h