* [PATCH] net: dsa: mv88e6xxx: fix boolreturn.cocci warnings
[not found] <201803062304.hS8xIhIb%fengguang.wu@intel.com>
@ 2018-03-06 15:54 ` kbuild test robot
2018-03-06 16:02 ` Andrew Lunn
2018-03-07 18:37 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: kbuild test robot @ 2018-03-06 15:54 UTC (permalink / raw)
To: Andrew Lunn
Cc: kbuild-all, Vivien Didelot, Florian Fainelli, netdev,
linux-kernel
From: Fengguang Wu <fengguang.wu@intel.com>
drivers/net/dsa/mv88e6xxx/serdes.c:66:9-10: WARNING: return of 0/1 in function 'mv88e6352_port_has_serdes' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
Fixes: eb755c3f6b7d ("net: dsa: mv88e6xxx: Add helper to determining if port has SERDES")
CC: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
serdes.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- a/drivers/net/dsa/mv88e6xxx/serdes.c
+++ b/drivers/net/dsa/mv88e6xxx/serdes.c
@@ -63,15 +63,15 @@ static bool mv88e6352_port_has_serdes(st
err = mv88e6xxx_port_get_cmode(chip, port, &cmode);
if (err) {
dev_err(chip->dev, "failed to read cmode\n");
- return 0;
+ return false;
}
if ((cmode == MV88E6XXX_PORT_STS_CMODE_100BASE_X) ||
(cmode == MV88E6XXX_PORT_STS_CMODE_1000BASE_X) ||
(cmode == MV88E6XXX_PORT_STS_CMODE_SGMII))
- return 1;
+ return true;
- return 0;
+ return false;
}
int mv88e6352_serdes_power(struct mv88e6xxx_chip *chip, int port, bool on)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: dsa: mv88e6xxx: fix boolreturn.cocci warnings
2018-03-06 15:54 ` [PATCH] net: dsa: mv88e6xxx: fix boolreturn.cocci warnings kbuild test robot
@ 2018-03-06 16:02 ` Andrew Lunn
2018-03-07 18:37 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2018-03-06 16:02 UTC (permalink / raw)
To: kbuild test robot
Cc: kbuild-all, Vivien Didelot, Florian Fainelli, netdev,
linux-kernel
On Tue, Mar 06, 2018 at 11:54:07PM +0800, kbuild test robot wrote:
> From: Fengguang Wu <fengguang.wu@intel.com>
>
> drivers/net/dsa/mv88e6xxx/serdes.c:66:9-10: WARNING: return of 0/1 in function 'mv88e6352_port_has_serdes' with return type bool
>
> Return statements in functions returning bool should use
> true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
>
> Fixes: eb755c3f6b7d ("net: dsa: mv88e6xxx: Add helper to determining if port has SERDES")
> CC: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: dsa: mv88e6xxx: fix boolreturn.cocci warnings
2018-03-06 15:54 ` [PATCH] net: dsa: mv88e6xxx: fix boolreturn.cocci warnings kbuild test robot
2018-03-06 16:02 ` Andrew Lunn
@ 2018-03-07 18:37 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-03-07 18:37 UTC (permalink / raw)
To: fengguang.wu
Cc: andrew, kbuild-all, vivien.didelot, f.fainelli, netdev,
linux-kernel
From: kbuild test robot <fengguang.wu@intel.com>
Date: Tue, 6 Mar 2018 23:54:07 +0800
> From: Fengguang Wu <fengguang.wu@intel.com>
>
> drivers/net/dsa/mv88e6xxx/serdes.c:66:9-10: WARNING: return of 0/1 in function 'mv88e6352_port_has_serdes' with return type bool
>
> Return statements in functions returning bool should use
> true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
>
> Fixes: eb755c3f6b7d ("net: dsa: mv88e6xxx: Add helper to determining if port has SERDES")
> CC: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Applied to net-next.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-07 18:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <201803062304.hS8xIhIb%fengguang.wu@intel.com>
2018-03-06 15:54 ` [PATCH] net: dsa: mv88e6xxx: fix boolreturn.cocci warnings kbuild test robot
2018-03-06 16:02 ` Andrew Lunn
2018-03-07 18:37 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).