From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbuild test robot Subject: [PATCH] net: dsa: mv88e6xxx: fix boolreturn.cocci warnings Date: Tue, 6 Mar 2018 23:54:07 +0800 Message-ID: <20180306155407.GA67333@lkp-g5> References: <201803062304.hS8xIhIb%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kbuild-all@01.org, Vivien Didelot , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Andrew Lunn Return-path: Content-Disposition: inline In-Reply-To: <201803062304.hS8xIhIb%fengguang.wu@intel.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Fengguang Wu drivers/net/dsa/mv88e6xxx/serdes.c:66:9-10: WARNING: return of 0/1 in function 'mv88e6352_port_has_serdes' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci Fixes: eb755c3f6b7d ("net: dsa: mv88e6xxx: Add helper to determining if port has SERDES") CC: Andrew Lunn Signed-off-by: Fengguang Wu --- serdes.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/drivers/net/dsa/mv88e6xxx/serdes.c +++ b/drivers/net/dsa/mv88e6xxx/serdes.c @@ -63,15 +63,15 @@ static bool mv88e6352_port_has_serdes(st err = mv88e6xxx_port_get_cmode(chip, port, &cmode); if (err) { dev_err(chip->dev, "failed to read cmode\n"); - return 0; + return false; } if ((cmode == MV88E6XXX_PORT_STS_CMODE_100BASE_X) || (cmode == MV88E6XXX_PORT_STS_CMODE_1000BASE_X) || (cmode == MV88E6XXX_PORT_STS_CMODE_SGMII)) - return 1; + return true; - return 0; + return false; } int mv88e6352_serdes_power(struct mv88e6xxx_chip *chip, int port, bool on)