From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:48975 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753864AbeCFQ7d (ORCPT <rfc822;netdev@vger.kernel.org>);
        Tue, 6 Mar 2018 11:59:33 -0500
Date: Tue, 6 Mar 2018 17:59:28 +0100
From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
        David Miller <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v2 net-next 1/2] net: phy: remove phy_error from
 phy_disable_interrupts
Message-ID: <20180306165928.GC1244@lunn.ch>
References: <7a212841-6499-18be-b646-33ea69fb7da2@gmail.com>
 <8455599b-bb1f-5710-b67f-1c48fdb9271c@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8455599b-bb1f-5710-b67f-1c48fdb9271c@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, Mar 05, 2018 at 10:34:27PM +0100, Heiner Kallweit wrote:
> All callers of phy_disable_interrupts() call phy_error() in the error
> case. Therefore we don't need to do this within the function too.
> This change also allows us to use phy_disable_interrupts() in code
> holding phydev->lock (because phy_error() can take this lock).
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew