From: kbuild test robot <fengguang.wu@intel.com>
To: Govindarajulu Varadarajan <gvaradar@cisco.com>
Cc: kbuild-all@01.org, Christian Benvenuti <benve@cisco.com>,
Parvi Kaustubhi <pkaustub@cisco.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] enic: fix boolreturn.cocci warnings
Date: Wed, 7 Mar 2018 02:23:23 +0800 [thread overview]
Message-ID: <20180306182323.GA127477@lkp-g5> (raw)
In-Reply-To: <201803070200.EDzyfosu%fengguang.wu@intel.com>
From: Fengguang Wu <fengguang.wu@intel.com>
drivers/net/ethernet/cisco/enic/vnic_dev.c:1294:9-10: WARNING: return of 0/1 in function 'vnic_dev_capable_udp_rss' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
Fixes: 48398b6e7065 ("enic: set UDP rss flag")
CC: Govindarajulu Varadarajan <gvaradar@cisco.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
vnic_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/ethernet/cisco/enic/vnic_dev.c
+++ b/drivers/net/ethernet/cisco/enic/vnic_dev.c
@@ -1291,7 +1291,7 @@ bool vnic_dev_capable_udp_rss(struct vni
err = vnic_dev_cmd(vdev, CMD_CAPABILITY, &a0, &a1, wait);
if (err || !a0)
- return 0;
+ return false;
rss_hash_type = (a1 >> NIC_CFG_RSS_HASH_TYPE_SHIFT) &
NIC_CFG_RSS_HASH_TYPE_MASK_FIELD;
next parent reply other threads:[~2018-03-06 18:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201803070200.EDzyfosu%fengguang.wu@intel.com>
2018-03-06 18:23 ` kbuild test robot [this message]
2018-03-07 18:37 ` [PATCH] enic: fix boolreturn.cocci warnings David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180306182323.GA127477@lkp-g5 \
--to=fengguang.wu@intel.com \
--cc=benve@cisco.com \
--cc=gvaradar@cisco.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkaustub@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).