From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbuild test robot Subject: [PATCH] enic: fix boolreturn.cocci warnings Date: Wed, 7 Mar 2018 02:23:23 +0800 Message-ID: <20180306182323.GA127477@lkp-g5> References: <201803070200.EDzyfosu%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kbuild-all@01.org, Christian Benvenuti , Parvi Kaustubhi , netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Govindarajulu Varadarajan Return-path: Content-Disposition: inline In-Reply-To: <201803070200.EDzyfosu%fengguang.wu@intel.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Fengguang Wu drivers/net/ethernet/cisco/enic/vnic_dev.c:1294:9-10: WARNING: return of 0/1 in function 'vnic_dev_capable_udp_rss' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci Fixes: 48398b6e7065 ("enic: set UDP rss flag") CC: Govindarajulu Varadarajan Signed-off-by: Fengguang Wu --- vnic_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/cisco/enic/vnic_dev.c +++ b/drivers/net/ethernet/cisco/enic/vnic_dev.c @@ -1291,7 +1291,7 @@ bool vnic_dev_capable_udp_rss(struct vni err = vnic_dev_cmd(vdev, CMD_CAPABILITY, &a0, &a1, wait); if (err || !a0) - return 0; + return false; rss_hash_type = (a1 >> NIC_CFG_RSS_HASH_TYPE_SHIFT) & NIC_CFG_RSS_HASH_TYPE_MASK_FIELD;