From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f47.google.com ([74.125.83.47]:40020 "EHLO
        mail-pg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932078AbeCGCom (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 6 Mar 2018 21:44:42 -0500
Received: by mail-pg0-f47.google.com with SMTP id g8so354418pgv.7
        for <netdev@vger.kernel.org>; Tue, 06 Mar 2018 18:44:42 -0800 (PST)
Date: Tue, 6 Mar 2018 18:44:39 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Roopa Prabhu <roopa@cumulusnetworks.com>
Cc: dsahern@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 net-next v3] iprule: support for ip_proto,
 sport and dport match options
Message-ID: <20180306184439.1a93d7d4@xeon-e3>
In-Reply-To: <1520388479-15520-1-git-send-email-roopa@cumulusnetworks.com>
References: <1520388479-15520-1-git-send-email-roopa@cumulusnetworks.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue,  6 Mar 2018 18:07:59 -0800
Roopa Prabhu <roopa@cumulusnetworks.com> wrote:

> +	if (tb[FRA_IP_PROTO]) {
> +		SPRINT_BUF(pbuf);
> +		fprintf(fp, "ip_proto %s ",
> +			inet_proto_n2a(rta_getattr_u8(tb[FRA_IP_PROTO]), pbuf,
> +				       sizeof(pbuf)));
> +	}
> +
> +	if (tb[FRA_SPORT_RANGE]) {
> +		struct fib_rule_port_range *r = RTA_DATA(tb[FRA_SPORT_RANGE]);
> +
> +		if (r->start == r->end)
> +			fprintf(fp, "sport %hu ", r->start);
> +		else
> +			fprintf(fp, "sport %hu-%hu ", r->start, r->end);
> +	}
> +
> +	if (tb[FRA_DPORT_RANGE]) {
> +		struct fib_rule_port_range *r = RTA_DATA(tb[FRA_DPORT_RANGE]);
> +
> +		if (r->start == r->end)
> +			fprintf(fp, "dport %hu ", r->start);
> +		else
> +			fprintf(fp, "dport %hu-%hu ", r->start, r->end);
> +	}
> +

in net-next this is all JSON now.