netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: David Ahern <dsahern@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	"Wei Wang" <weiwan@google.com>,
	"Hideaki YOSHIFUJI" <yoshfuji@linux-ipv6.org>,
	"Maciej Żenczykowski" <maze@google.com>,
	"Xiumei Mu" <xmu@redhat.com>,
	netdev@vger.kernel.org
Subject: Re: [PATCH net v2 RESEND] ipv6: Reflect MTU changes on PMTU of exceptions for MTU-less routes
Date: Tue, 6 Mar 2018 22:07:31 +0100	[thread overview]
Message-ID: <20180306220731.3c508950@epycfail> (raw)
In-Reply-To: <3f248c84-9c5a-be26-25e9-455024ac3c54@gmail.com>

On Tue, 6 Mar 2018 13:30:05 -0700
David Ahern <dsahern@gmail.com> wrote:

> On 3/6/18 3:10 AM, Stefano Brivio wrote:
> > Currently, administrative MTU changes on a given netdevice are
> > not reflected on route exceptions for MTU-less routes, with a
> > set PMTU value, for that device:
> > 
> >  # ip -6 route get 2001:db8::b
> >  2001:db8::b from :: dev vti_a proto kernel src 2001:db8::a metric 256 pref medium
> >  # ping6 -c 1 -q -s10000 2001:db8::b > /dev/null
> >  # ip netns exec a ip -6 route get 2001:db8::b
> >  2001:db8::b from :: dev vti_a src 2001:db8::a metric 0
> >      cache expires 571sec mtu 4926 pref medium
> >  # ip link set dev vti_a mtu 3000
> >  # ip -6 route get 2001:db8::b
> >  2001:db8::b from :: dev vti_a src 2001:db8::a metric 0
> >      cache expires 571sec mtu 4926 pref medium
> >  # ip link set dev vti_a mtu 9000
> >  # ip -6 route get 2001:db8::b
> >  2001:db8::b from :: dev vti_a src 2001:db8::a metric 0
> >      cache expires 571sec mtu 4926 pref medium  
> 
> Using your test script, I never see the route get an updated MTU -- it
> is always 1426.
> 
> ++ exception='fd00:2::b from :: dev vti_a src fd00:2::a metric 0 expires
> 598sec mtu 1426 pref medium'

Thanks for reporting this.

There's another issue in the test script: the initial PMTU of the
exception depends on the veth MTU value, which I'm not explicitly
setting. It happened to be 5000 on my host, it's a more reasonable 1500
on yours.

If you have 1426 as initial PMTU, by setting the MTU to 3000 as second
step in the script, I'm clearly not decreasing it.

I'll send a v3 of the test script.

-- 
Stefano

  reply	other threads:[~2018-03-06 21:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-06 10:10 [PATCH net v2 RESEND] ipv6: Reflect MTU changes on PMTU of exceptions for MTU-less routes Stefano Brivio
2018-03-06 20:30 ` David Ahern
2018-03-06 21:07   ` Stefano Brivio [this message]
2018-03-07  4:46 ` David Ahern
2018-03-07 18:18 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180306220731.3c508950@epycfail \
    --to=sbrivio@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=maze@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=weiwan@google.com \
    --cc=xmu@redhat.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).