* [PATCH] ravb: remove erroneous comment
@ 2018-03-03 22:39 Niklas Söderlund
2018-03-04 7:59 ` Sergei Shtylyov
2018-03-07 15:40 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Niklas Söderlund @ 2018-03-03 22:39 UTC (permalink / raw)
To: Sergei Shtylyov, David S . Miller, netdev
Cc: linux-renesas-soc, Niklas Söderlund
When addressing a review comment in a early version of the offending
patch a comment where left in which should have been removed. Remove the
comment to keep it consistent with the code.
Fixes: 75efa06f457bbed3 ("ravb: add support for changing MTU")
Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
drivers/net/ethernet/renesas/ravb_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index 54a6265da7a06460..68f122140966d4de 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -346,7 +346,6 @@ static int ravb_ring_init(struct net_device *ndev, int q)
int ring_size;
int i;
- /* +16 gets room from the status from the card. */
priv->rx_buf_sz = (ndev->mtu <= 1492 ? PKT_BUF_SZ : ndev->mtu) +
ETH_HLEN + VLAN_HLEN;
--
2.16.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ravb: remove erroneous comment
2018-03-03 22:39 [PATCH] ravb: remove erroneous comment Niklas Söderlund
@ 2018-03-04 7:59 ` Sergei Shtylyov
2018-03-07 15:40 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2018-03-04 7:59 UTC (permalink / raw)
To: Niklas Söderlund, David S . Miller, netdev; +Cc: linux-renesas-soc
Hello!
On 3/4/2018 1:39 AM, Niklas Söderlund wrote:
> When addressing a review comment in a early version of the offending
> patch a comment where left in which should have been removed. Remove the
s/where/was/?
> comment to keep it consistent with the code.
>
> Fixes: 75efa06f457bbed3 ("ravb: add support for changing MTU")
> Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ravb: remove erroneous comment
2018-03-03 22:39 [PATCH] ravb: remove erroneous comment Niklas Söderlund
2018-03-04 7:59 ` Sergei Shtylyov
@ 2018-03-07 15:40 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-03-07 15:40 UTC (permalink / raw)
To: niklas.soderlund+renesas; +Cc: sergei.shtylyov, netdev, linux-renesas-soc
From: Niklas S�derlund <niklas.soderlund+renesas@ragnatech.se>
Date: Sat, 3 Mar 2018 23:39:54 +0100
> When addressing a review comment in a early version of the offending
> patch a comment where left in which should have been removed. Remove the
> comment to keep it consistent with the code.
>
> Fixes: 75efa06f457bbed3 ("ravb: add support for changing MTU")
> Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Signed-off-by: Niklas S�derlund <niklas.soderlund+renesas@ragnatech.se>
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-07 15:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-03 22:39 [PATCH] ravb: remove erroneous comment Niklas Söderlund
2018-03-04 7:59 ` Sergei Shtylyov
2018-03-07 15:40 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).