From: David Miller <davem@davemloft.net>
To: paulb@mellanox.com
Cc: tgraf@suug.ch, herbert@gondor.apana.org.au,
netdev@vger.kernel.org, kliteyn@mellanox.com, roid@mellanox.com,
shahark@mellanox.com, markb@mellanox.com, jiri@mellanox.com,
ogerlitz@mellanox.com, matanb@mellanox.com
Subject: Re: [PATCH net v4 0/2] rhashtable: Fix rhltable duplicates insertion
Date: Wed, 07 Mar 2018 11:23:42 -0500 (EST) [thread overview]
Message-ID: <20180307.112342.1350862113264771178.davem@davemloft.net> (raw)
In-Reply-To: <1520431213-61553-1-git-send-email-paulb@mellanox.com>
From: Paul Blakey <paulb@mellanox.com>
Date: Wed, 7 Mar 2018 16:00:11 +0200
> On our mlx5 driver fs_core.c, we use the rhltable interface to store
> flow groups. We noticed that sometimes we get a warning that flow group isn't
> found at removal. This rare case was caused when a specific scenario happened,
> insertion of a flow group with a similar match criteria (a duplicate),
> but only where the flow group rhash_head was second (or not first)
> on the relevant rhashtable bucket list.
>
> The first patch fixes it, and the second one adds a test that show
> it is now working.
>
> Paul.
>
> v4 --> v3 changes:
> * Added Herbert Xu's ack (thanks)
> * Removed extra commit tags
I already applied v3, sorry. But I did add Herbert's ACKs.
:-)
next prev parent reply other threads:[~2018-03-07 16:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 14:00 [PATCH net v4 0/2] rhashtable: Fix rhltable duplicates insertion Paul Blakey
2018-03-07 14:00 ` [PATCH net v4 1/2] rhashtable: Fix rhlist " Paul Blakey
2018-03-07 14:00 ` [PATCH net v4 2/2] test_rhashtable: add test case for rhltable with duplicate objects Paul Blakey
2018-03-07 16:23 ` David Miller [this message]
2018-03-08 8:01 ` [PATCH net v4 0/2] rhashtable: Fix rhltable duplicates insertion Paul Blakey
2018-03-11 9:16 ` Or Gerlitz
2018-03-12 2:48 ` David Miller
2018-03-12 6:40 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307.112342.1350862113264771178.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jiri@mellanox.com \
--cc=kliteyn@mellanox.com \
--cc=markb@mellanox.com \
--cc=matanb@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=paulb@mellanox.com \
--cc=roid@mellanox.com \
--cc=shahark@mellanox.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).