From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:53744 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933533AbeCGQXp (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 7 Mar 2018 11:23:45 -0500
Date: Wed, 07 Mar 2018 11:23:42 -0500 (EST)
Message-Id: <20180307.112342.1350862113264771178.davem@davemloft.net>
To: paulb@mellanox.com
Cc: tgraf@suug.ch, herbert@gondor.apana.org.au, netdev@vger.kernel.org,
        kliteyn@mellanox.com, roid@mellanox.com, shahark@mellanox.com,
        markb@mellanox.com, jiri@mellanox.com, ogerlitz@mellanox.com,
        matanb@mellanox.com
Subject: Re: [PATCH net v4 0/2] rhashtable: Fix rhltable duplicates
 insertion
From: David Miller <davem@davemloft.net>
In-Reply-To: <1520431213-61553-1-git-send-email-paulb@mellanox.com>
References: <1520431213-61553-1-git-send-email-paulb@mellanox.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Paul Blakey <paulb@mellanox.com>
Date: Wed,  7 Mar 2018 16:00:11 +0200

> On our mlx5 driver fs_core.c, we use the rhltable interface to store
> flow groups. We noticed that sometimes we get a warning that flow group isn't
> found at removal. This rare case was caused when a specific scenario happened,
> insertion of a flow group with a similar match criteria (a duplicate),
> but only where the flow group rhash_head was second (or not first)
> on the relevant rhashtable bucket list.
> 
> The first patch fixes it, and the second one adds a test that show
> it is now working.
> 
> Paul.
> 
> v4 --> v3 changes:
>     * Added Herbert Xu's ack (thanks)
>     * Removed extra commit tags

I already applied v3, sorry.  But I did add Herbert's ACKs.
:-)