From: David Miller <davem@davemloft.net>
To: arushisinghal19971997@gmail.com
Cc: jdmason@kudzu.us, jakub.kicinski@netronome.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
oss-drivers@netronome.com, outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v2] net: ethernet: Drop unnecessary continue
Date: Wed, 07 Mar 2018 12:01:47 -0500 (EST) [thread overview]
Message-ID: <20180307.120147.195464731584241423.davem@davemloft.net> (raw)
In-Reply-To: <CA+XqjF8_axeTnahPmokxmDnm4NmWo8QWSEmLejN4fO1nAiDaBA@mail.gmail.com>
From: Arushi Singhal <arushisinghal19971997@gmail.com>
Date: Wed, 7 Mar 2018 22:22:13 +0530
> Yes I know it's for the inner loop.
> But I am not able to find, where I am wrong here
You are making what is essentially a nop change to a piece of code,
which if you had instead read carefully would have instead inspired
you to fix a real genuine bug instead.
next prev parent reply other threads:[~2018-03-07 17:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-03 16:14 [PATCH v2] net: ethernet: Drop unnecessary continue Arushi Singhal
2018-03-05 1:57 ` Jakub Kicinski
2018-03-07 15:39 ` David Miller
[not found] ` <CA+XqjF8_axeTnahPmokxmDnm4NmWo8QWSEmLejN4fO1nAiDaBA@mail.gmail.com>
2018-03-07 17:01 ` David Miller [this message]
2018-03-07 19:41 ` [Outreachy kernel] " Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307.120147.195464731584241423.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arushisinghal19971997@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).