From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:54586 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754039AbeCGRag (ORCPT ); Wed, 7 Mar 2018 12:30:36 -0500 Date: Wed, 07 Mar 2018 12:30:34 -0500 (EST) Message-Id: <20180307.123034.1743041083474599541.davem@davemloft.net> To: hkallweit1@gmail.com Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org Subject: Re: [PATCH v2 net-next 0/2] net: phy: remove phy_error from phy_disable_interrupts From: David Miller In-Reply-To: <7a212841-6499-18be-b646-33ea69fb7da2@gmail.com> References: <7a212841-6499-18be-b646-33ea69fb7da2@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: Heiner Kallweit Date: Mon, 5 Mar 2018 22:29:43 +0100 > All callers of phy_disable_interrupts() call phy_error() in the error > case. Therefore we don't need to do this within the function too. > This change also allows us to use phy_disable_interrupts() in code > holding phydev->lock (because phy_error() takes this lock). > Make use of this in phy_stop(). > > v2: > - splitted into two separate patches Series applied, thanks.