From: David Miller <davem@davemloft.net>
To: jeremy.linton@arm.com
Cc: netdev@vger.kernel.org, steve.glendinning@shawell.net,
matt.sealey@arm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: smsc911x: Fix unload crash when link is up
Date: Wed, 07 Mar 2018 13:23:13 -0500 (EST) [thread overview]
Message-ID: <20180307.132313.862901353807914148.davem@davemloft.net> (raw)
In-Reply-To: <20180306150006.31512-1-jeremy.linton@arm.com>
From: Jeremy Linton <jeremy.linton@arm.com>
Date: Tue, 6 Mar 2018 09:00:06 -0600
> The smsc911x driver will crash if it is rmmod'ed while the netdev
> is up like:
>
> Call trace:
...
> This is caused by the mdiobus being unregistered/free'd
> and the code in phy_detach() attempting to manipulate mdio
> related structures from unregister_netdev() calling close()
>
> To fix this, we delay the mdiobus teardown until after
> the netdev is deregistered.
>
> Reported-by: Matt Sealey <matt.sealey@arm.com>
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
Applied, thanks.
prev parent reply other threads:[~2018-03-07 18:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 15:00 [PATCH] net: smsc911x: Fix unload crash when link is up Jeremy Linton
2018-03-06 15:23 ` Andrew Lunn
2018-03-06 15:40 ` Jeremy Linton
2018-03-07 18:23 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307.132313.862901353807914148.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jeremy.linton@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.sealey@arm.com \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).