From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: smsc911x: Fix unload crash when link is up Date: Wed, 07 Mar 2018 13:23:13 -0500 (EST) Message-ID: <20180307.132313.862901353807914148.davem@davemloft.net> References: <20180306150006.31512-1-jeremy.linton@arm.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, steve.glendinning@shawell.net, matt.sealey@arm.com, linux-kernel@vger.kernel.org To: jeremy.linton@arm.com Return-path: In-Reply-To: <20180306150006.31512-1-jeremy.linton@arm.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Jeremy Linton Date: Tue, 6 Mar 2018 09:00:06 -0600 > The smsc911x driver will crash if it is rmmod'ed while the netdev > is up like: > > Call trace: ... > This is caused by the mdiobus being unregistered/free'd > and the code in phy_detach() attempting to manipulate mdio > related structures from unregister_netdev() calling close() > > To fix this, we delay the mdiobus teardown until after > the netdev is deregistered. > > Reported-by: Matt Sealey > Signed-off-by: Jeremy Linton Applied, thanks.