From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:55450 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751220AbeCGSgw (ORCPT ); Wed, 7 Mar 2018 13:36:52 -0500 Date: Wed, 07 Mar 2018 13:36:51 -0500 (EST) Message-Id: <20180307.133651.2158882031803330781.davem@davemloft.net> To: eric.dumazet@gmail.com Cc: netdev@vger.kernel.org, jchapman@katalix.com, g.nault@alphalink.fr Subject: Re: [PATCH net] l2tp: do not accept arbitrary sockets From: David Miller In-Reply-To: <1520351693.109662.17.camel@gmail.com> References: <1520351693.109662.17.camel@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: Eric Dumazet Date: Tue, 06 Mar 2018 07:54:53 -0800 > From: Eric Dumazet > > syzkaller found an issue caused by lack of sufficient checks > in l2tp_tunnel_create() > > RAW sockets can not be considered as UDP ones for instance. > > In another patch, we shall replace all pr_err() by less intrusive > pr_debug() so that syzkaller can find other bugs faster. ... > Fixes: fd558d186df2 ("l2tp: Split pppol2tp patch into separate l2tp and ppp parts") > Signed-off-by: Eric Dumazet > Reported-by: syzbot Applied and queued up for -stable, thanks.