From: David Miller <davem@davemloft.net>
To: mrv@mojatatu.com
Cc: netdev@vger.kernel.org, kernel@mojatatu.com, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us
Subject: Re: [PATCH v2 net-next 3/4] net sched actions: calculate add/delete event message size
Date: Wed, 07 Mar 2018 14:55:52 -0500 (EST) [thread overview]
Message-ID: <20180307.145552.823990283862234485.davem@davemloft.net> (raw)
In-Reply-To: <1520373324-17433-4-git-send-email-mrv@mojatatu.com>
From: Roman Mashak <mrv@mojatatu.com>
Date: Tue, 6 Mar 2018 16:55:23 -0500
> +static size_t tcf_action_fill_size(const struct tc_action *act)
> +{
> + if (act->ops->get_fill_size)
> + return act->ops->get_fill_size(act) +
> + tcf_action_shared_attrs_size(act);
> + return 0;
> +}
I don't understand this.
The shared attrs should be considered regardless of whether an action
type specific ->get_fill_size() is implemented.
But instead, you return zero in that case.
next prev parent reply other threads:[~2018-03-07 19:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 21:55 [PATCH v2 net-next 0/4] Fix event generation for actions batch Add/Delete mode Roman Mashak
2018-03-06 21:55 ` [PATCH v2 net-next 1/4] net sched actions: update Add/Delete action API with new argument Roman Mashak
2018-03-06 21:55 ` [PATCH v2 net-next 2/4] net sched actions: add new tc_action_ops callback Roman Mashak
2018-03-06 21:55 ` [PATCH v2 net-next 3/4] net sched actions: calculate add/delete event message size Roman Mashak
2018-03-07 19:55 ` David Miller [this message]
2018-03-07 20:43 ` Roman Mashak
2018-03-06 21:55 ` [PATCH v2 net-next 4/4] net sched actions: implement get_fill_size routine in act_gact Roman Mashak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307.145552.823990283862234485.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kernel@mojatatu.com \
--cc=mrv@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).