From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:56372 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S935053AbeCGTz4 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 7 Mar 2018 14:55:56 -0500
Date: Wed, 07 Mar 2018 14:55:52 -0500 (EST)
Message-Id: <20180307.145552.823990283862234485.davem@davemloft.net>
To: mrv@mojatatu.com
Cc: netdev@vger.kernel.org, kernel@mojatatu.com, jhs@mojatatu.com,
        xiyou.wangcong@gmail.com, jiri@resnulli.us
Subject: Re: [PATCH v2 net-next 3/4] net sched actions: calculate
 add/delete event message size
From: David Miller <davem@davemloft.net>
In-Reply-To: <1520373324-17433-4-git-send-email-mrv@mojatatu.com>
References: <1520373324-17433-1-git-send-email-mrv@mojatatu.com>
        <1520373324-17433-4-git-send-email-mrv@mojatatu.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Roman Mashak <mrv@mojatatu.com>
Date: Tue,  6 Mar 2018 16:55:23 -0500

> +static size_t tcf_action_fill_size(const struct tc_action *act)
> +{
> +	if (act->ops->get_fill_size)
> +		return act->ops->get_fill_size(act) +
> +			tcf_action_shared_attrs_size(act);
> +	return 0;
> +}

I don't understand this.

The shared attrs should be considered regardless of whether an action
type specific ->get_fill_size() is implemented.

But instead, you return zero in that case.