From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:56438 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S934877AbeCGUBi (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 7 Mar 2018 15:01:38 -0500
Date: Wed, 07 Mar 2018 15:01:36 -0500 (EST)
Message-Id: <20180307.150136.839618086949491431.davem@davemloft.net>
To: soheil.kdev@gmail.com
Cc: netdev@vger.kernel.org, willemb@google.com, soheil@google.com,
        ncardwell@google.com, ycheng@google.com
Subject: Re: [PATCH net] tcp: purge write queue upon aborting the connection
From: David Miller <davem@davemloft.net>
In-Reply-To: <20180306221512.119943-1-soheil.kdev@gmail.com>
References: <20180306221512.119943-1-soheil.kdev@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Soheil Hassas Yeganeh <soheil.kdev@gmail.com>
Date: Tue,  6 Mar 2018 17:15:12 -0500

> From: Soheil Hassas Yeganeh <soheil@google.com>
> 
> When the connection is aborted, there is no point in
> keeping the packets on the write queue until the connection
> is closed.
> 
> Similar to a27fd7a8ed38 ('tcp: purge write queue upon RST'),
> this is essential for a correct MSG_ZEROCOPY implementation,
> because userspace cannot call close(fd) before receiving
> zerocopy signals even when the connection is aborted.
> 
> Fixes: f214f915e7db ("tcp: enable MSG_ZEROCOPY")
> Signed-off-by: Soheil Hassas Yeganeh <soheil@google.com>
> Signed-off-by: Neal Cardwell <ncardwell@google.com>
> Reviewed-by: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Yuchung Cheng <ycheng@google.com>

Applied and queued up for -stable, thanks.