From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:56874 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S934521AbeCGUjs (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 7 Mar 2018 15:39:48 -0500
Date: Wed, 07 Mar 2018 15:39:46 -0500 (EST)
Message-Id: <20180307.153946.1114486193485019127.davem@davemloft.net>
To: johan@kernel.org
Cc: oliver@neukum.org, linux-usb@vger.kernel.org,
        netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] net: kalmia: clean up bind error path
From: David Miller <davem@davemloft.net>
In-Reply-To: <20180307094658.9008-1-johan@kernel.org>
References: <20180307094658.9008-1-johan@kernel.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Johan Hovold <johan@kernel.org>
Date: Wed,  7 Mar 2018 10:46:57 +0100

> Drop bogus call to usb_driver_release_interface() from an error path in
> the usbnet bind() callback, which is called during interface probe. At
> this point the interface is not bound and usb_driver_release_interface()
> returns early.
> 
> Also remove the bogus call to clear the interface data, which is owned
> by the usbnet driver and would not even have been set by the time bind()
> is called.
> 
> Signed-off-by: Johan Hovold <johan@kernel.org>

Applied.