[patch net-next 0/2] selftests: forwarding: couple of fixes

[patch net-next 0/2] selftests: forwarding: couple of fixes

[Jiri Pirko]

From: Jiri Pirko <jiri@mellanox.com>

Jiri Pirko (2):
  selftests: forwarding: fix "ok" action test
  selftests: forwarding: fix flags passed to first drop rule in
    gact_drop_and_ok_test

 tools/testing/selftests/net/forwarding/tc_actions.sh | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

-- 
2.14.3

[patch net-next 1/2] selftests: forwarding: fix "ok" action test

[Jiri Pirko]

From: Jiri Pirko <jiri@mellanox.com>

Fix the "ok" action test so it checks that packet that is okayed does not
continue to be processed by other rules. Fix error message as well.

Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
---
 tools/testing/selftests/net/forwarding/tc_actions.sh | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/forwarding/tc_actions.sh b/tools/testing/selftests/net/forwarding/tc_actions.sh
index 6b18ba2d3982..ac6b6a1057d8 100755
--- a/tools/testing/selftests/net/forwarding/tc_actions.sh
+++ b/tools/testing/selftests/net/forwarding/tc_actions.sh
@@ -96,7 +96,10 @@ gact_drop_and_ok_test()
 		-t ip -q
 
 	tc_check_packets "dev $swp1 ingress" 101 1
-	check_err $? "Did not see trapped packet"
+	check_err $? "Did not see passed packet"
+
+	tc_check_packets "dev $swp1 ingress" 102 2
+	check_fail $? "Packet was dropped and it should not reach here"
 
 	tc filter del dev $swp1 ingress protocol ip pref 2 handle 102 flower
 	tc filter del dev $swp1 ingress protocol ip pref 1 handle 101 flower
-- 
2.14.3

Re: [patch net-next 1/2] selftests: forwarding: fix "ok" action test

[David Miller]

From: Jiri Pirko <jiri@resnulli.us>
Date: Wed,  7 Mar 2018 13:57:59 +0100

> From: Jiri Pirko <jiri@mellanox.com>
> 
> Fix the "ok" action test so it checks that packet that is okayed does not
> continue to be processed by other rules. Fix error message as well.
> 
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
> Reviewed-by: Ido Schimmel <idosch@mellanox.com>

Applied.

[patch net-next 2/2] selftests: forwarding: fix flags passed to first drop rule in gact_drop_and_ok_test

[Jiri Pirko]

From: Jiri Pirko <jiri@mellanox.com>

Fix copy&paste error and pass proper flags.

Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
---
 tools/testing/selftests/net/forwarding/tc_actions.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/forwarding/tc_actions.sh b/tools/testing/selftests/net/forwarding/tc_actions.sh
index ac6b6a1057d8..3a6385ebd5d0 100755
--- a/tools/testing/selftests/net/forwarding/tc_actions.sh
+++ b/tools/testing/selftests/net/forwarding/tc_actions.sh
@@ -81,7 +81,7 @@ gact_drop_and_ok_test()
 	RET=0
 
 	tc filter add dev $swp1 ingress protocol ip pref 2 handle 102 flower \
-		skip_hw dst_ip 192.0.2.2 action drop
+		$tcflags dst_ip 192.0.2.2 action drop
 
 	$MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac -A 192.0.2.1 -B 192.0.2.2 \
 		-t ip -q
-- 
2.14.3

Re: [patch net-next 2/2] selftests: forwarding: fix flags passed to first drop rule in gact_drop_and_ok_test

[David Miller]

From: Jiri Pirko <jiri@resnulli.us>
Date: Wed,  7 Mar 2018 13:58:00 +0100

> From: Jiri Pirko <jiri@mellanox.com>
> 
> Fix copy&paste error and pass proper flags.
> 
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
> Reviewed-by: Ido Schimmel <idosch@mellanox.com>

Applied.