From: David Miller <davem@davemloft.net>
To: gustavo@embeddedor.com
Cc: santosh@chelsio.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, garsilva@embeddedor.com
Subject: Re: [PATCH v2] cxgb3: remove VLA usage
Date: Wed, 07 Mar 2018 15:56:14 -0500 (EST) [thread overview]
Message-ID: <20180307.155614.873104283081437904.davem@davemloft.net> (raw)
In-Reply-To: <20180307180333.GA13800@embeddedgus>
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Date: Wed, 7 Mar 2018 12:03:33 -0600
> Remove VLA usage and change the 'len' argument to a u8 and use a 256
> byte buffer on the stack. Notice that these lengths are limited by the
> encoding field in the VPD structure, which is a u8 [1].
>
> [1] https://marc.info/?l=linux-netdev&m=152044354814024&w=2
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> Changes in v2:
> - Update the code as suggested by David Miller.
> - Update changelog based on David's comments.
> - Update subject.
Applied to net-next, thanks.
prev parent reply other threads:[~2018-03-07 20:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 18:03 [PATCH v2] cxgb3: remove VLA usage Gustavo A. R. Silva
2018-03-07 20:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307.155614.873104283081437904.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=garsilva@embeddedor.com \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=santosh@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).